jenkins-bot has submitted this change and it was merged.

Change subject: Log warnings from LangLinkHandler::getEntityLinks in production
......................................................................


Log warnings from LangLinkHandler::getEntityLinks in production

Seems like a good thing to do in general, because in these
cases we can't show any language links.

Change-Id: Ied0fdcd7a7ea67fb0c5af20b6e67804549e81da9
Note: I don't think this is related to T47839.
---
M client/includes/LangLinkHandler.php
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Aude: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/client/includes/LangLinkHandler.php 
b/client/includes/LangLinkHandler.php
index ca4112d..335b0f1 100644
--- a/client/includes/LangLinkHandler.php
+++ b/client/includes/LangLinkHandler.php
@@ -115,7 +115,7 @@
                                $links = iterator_to_array( 
$item->getSiteLinkList() );
                                $links = $this->indexLinksBySiteId( $links );
                        } else {
-                               wfWarn( __METHOD__ . ": Could not load item " . 
$itemId->getSerialization()
+                               wfLogWarning( __METHOD__ . ": Could not load 
item " . $itemId->getSerialization()
                                        . " for " . $title->getFullText() );
                        }
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/265924
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied0fdcd7a7ea67fb0c5af20b6e67804549e81da9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Hoo man <[email protected]>
Gerrit-Reviewer: Aude <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to