Santhosh has uploaded a new change for review. https://gerrit.wikimedia.org/r/269084
Change subject: Log the interlanguagelink CTA shown even only when it is open ...................................................................... Log the interlanguagelink CTA shown even only when it is open Logging it everytime the link is shown among the interlanguage link cause high number of records in our event logging tables. They are not helpful. Change-Id: I6b60c29973f02c975aad3da6639c8560af39eed0 --- M modules/entrypoint/ext.cx.entrypoint.js M modules/entrypoint/ext.cx.interlanguagelink.js 2 files changed, 1 insertion(+), 2 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ContentTranslation refs/changes/84/269084/1 diff --git a/modules/entrypoint/ext.cx.entrypoint.js b/modules/entrypoint/ext.cx.entrypoint.js index 5fe38e3..19516cd 100644 --- a/modules/entrypoint/ext.cx.entrypoint.js +++ b/modules/entrypoint/ext.cx.entrypoint.js @@ -71,6 +71,7 @@ this.$closeIcon.one( 'click', $.proxy( this.hide, this ) ); this.$actionTranslate.one( 'click', $.proxy( this.startPageInCX, this ) ); this.$actionScratch.one( 'click', $.proxy( this.startFromScratch, this ) ); + mw.hook( 'mw.cx.cta.shown' ).fire( this.options.entryPointName ); }; /** diff --git a/modules/entrypoint/ext.cx.interlanguagelink.js b/modules/entrypoint/ext.cx.interlanguagelink.js index 47128fe..4047e82 100644 --- a/modules/entrypoint/ext.cx.interlanguagelink.js +++ b/modules/entrypoint/ext.cx.interlanguagelink.js @@ -127,8 +127,6 @@ return; } - mw.hook( 'mw.cx.cta.shown' ).fire( campaign ); - // We load the below modules only when required to show gray interlanguage links. // This is important since gray interlanguage links appear in along with articles. dependencies = [ 'ext.cx.entrypoint', 'jquery.uls.data' ]; -- To view, visit https://gerrit.wikimedia.org/r/269084 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I6b60c29973f02c975aad3da6639c8560af39eed0 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/ContentTranslation Gerrit-Branch: master Gerrit-Owner: Santhosh <santhosh.thottin...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits