jenkins-bot has submitted this change and it was merged.
Change subject: Log the interlanguagelink CTA shown even only when it is open
......................................................................
Log the interlanguagelink CTA shown even only when it is open
Logging it everytime the link is shown among the interlanguage link
cause high number of records in our event logging tables. They are
not helpful.
Bug: T126188
Change-Id: I6b60c29973f02c975aad3da6639c8560af39eed0
---
M modules/entrypoint/ext.cx.entrypoint.js
M modules/entrypoint/ext.cx.interlanguagelink.js
2 files changed, 1 insertion(+), 2 deletions(-)
Approvals:
Amire80: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/entrypoint/ext.cx.entrypoint.js
b/modules/entrypoint/ext.cx.entrypoint.js
index 5fe38e3..19516cd 100644
--- a/modules/entrypoint/ext.cx.entrypoint.js
+++ b/modules/entrypoint/ext.cx.entrypoint.js
@@ -71,6 +71,7 @@
this.$closeIcon.one( 'click', $.proxy( this.hide, this ) );
this.$actionTranslate.one( 'click', $.proxy(
this.startPageInCX, this ) );
this.$actionScratch.one( 'click', $.proxy(
this.startFromScratch, this ) );
+ mw.hook( 'mw.cx.cta.shown' ).fire( this.options.entryPointName
);
};
/**
diff --git a/modules/entrypoint/ext.cx.interlanguagelink.js
b/modules/entrypoint/ext.cx.interlanguagelink.js
index 47128fe..4047e82 100644
--- a/modules/entrypoint/ext.cx.interlanguagelink.js
+++ b/modules/entrypoint/ext.cx.interlanguagelink.js
@@ -127,8 +127,6 @@
return;
}
- mw.hook( 'mw.cx.cta.shown' ).fire( campaign );
-
// We load the below modules only when required to show gray
interlanguage links.
// This is important since gray interlanguage links appear in
along with articles.
dependencies = [ 'ext.cx.entrypoint', 'jquery.uls.data' ];
--
To view, visit https://gerrit.wikimedia.org/r/269084
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6b60c29973f02c975aad3da6639c8560af39eed0
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/ContentTranslation
Gerrit-Branch: master
Gerrit-Owner: Santhosh <[email protected]>
Gerrit-Reviewer: Amire80 <[email protected]>
Gerrit-Reviewer: KartikMistry <[email protected]>
Gerrit-Reviewer: Nikerabbit <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
