jenkins-bot has submitted this change and it was merged.
Change subject: MenuSelectWidget: Ensure currently selected element is visible
when menu opens
......................................................................
MenuSelectWidget: Ensure currently selected element is visible when menu opens
Also, support duration of 0 in Element.static.scrollIntoView.
Bug: T125736
Change-Id: I58d8d412464f5f6b13368568e5b5a8ff0c7f147b
---
M src/Element.js
M src/widgets/MenuSelectWidget.js
2 files changed, 5 insertions(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/src/Element.js b/src/Element.js
index 6b770a5..992064f 100644
--- a/src/Element.js
+++ b/src/Element.js
@@ -621,7 +621,7 @@
}
}
if ( !$.isEmptyObject( anim ) ) {
- $sc.stop( true ).animate( anim, config.duration || 'fast' );
+ $sc.stop( true ).animate( anim, config.duration === undefined ?
'fast' : config.duration );
if ( callback ) {
$sc.queue( function ( next ) {
callback();
diff --git a/src/widgets/MenuSelectWidget.js b/src/widgets/MenuSelectWidget.js
index 4e661ca..0f4a269 100644
--- a/src/widgets/MenuSelectWidget.js
+++ b/src/widgets/MenuSelectWidget.js
@@ -291,6 +291,10 @@
}
this.toggleClipping( true );
+ if ( this.getSelectedItem() ) {
+ this.getSelectedItem().scrollElementIntoView( {
duration: 0 } );
+ }
+
// Auto-hide
if ( this.autoHide ) {
this.getElementDocument().addEventListener(
'mousedown', this.onDocumentMouseDownHandler, true );
--
To view, visit https://gerrit.wikimedia.org/r/269158
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58d8d412464f5f6b13368568e5b5a8ff0c7f147b
Gerrit-PatchSet: 4
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: Prtksxna <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
