ArielGlenn has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/269468

Change subject: Revert "Reload keyholder-agent on keyholder-auth change"
......................................................................

Revert "Reload keyholder-agent on keyholder-auth change"

This reverts commit a945f0619370c9d0809d4c1bc44e126436a48c08.

Caused puppet breakage on mira/tin:

Feb  5 18:17:54 mira puppet-agent[14031]: Could not apply complete catalog: 
Found 1 dependency cycle:
Feb  5 18:17:54 mira puppet-agent[14031]: 
(File[/etc/keyholder-auth.d/deploy-service.yml] => Service[keyholder-agent] => 
Class[Keyholder] => Class[Role::Deployment::Servi
ces] => Keyholder::Agent[deploy-service] => 
File[/etc/keyholder-auth.d/deploy-service.yml])

Change-Id: I637dba7222a9d6b47e0f6b5c485ca03bdc0e757b
---
M modules/keyholder/manifests/agent.pp
1 file changed, 0 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/68/269468/1

diff --git a/modules/keyholder/manifests/agent.pp 
b/modules/keyholder/manifests/agent.pp
index 8837f95..9c5426d 100644
--- a/modules/keyholder/manifests/agent.pp
+++ b/modules/keyholder/manifests/agent.pp
@@ -40,7 +40,6 @@
         owner   => 'root',
         group   => 'keyholder',
         mode    => '0440',
-        notify  => Service['keyholder-agent'],
     }
 
     # lint:ignore:puppet_url_without_modules

-- 
To view, visit https://gerrit.wikimedia.org/r/269468
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I637dba7222a9d6b47e0f6b5c485ca03bdc0e757b
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: ArielGlenn <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to