jenkins-bot has submitted this change and it was merged.
Change subject: Use global cache keys bad login rate limitting captcha trigger
......................................................................
Use global cache keys bad login rate limitting captcha trigger
If you are running multiple wikis, you probably want the rate limit
on one wiki to apply to all wikis
Bug: T126685
Change-Id: If5533f222eae9dc540b7c79606d7e7ce613f4e13
---
M SimpleCaptcha/Captcha.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/SimpleCaptcha/Captcha.php b/SimpleCaptcha/Captcha.php
index 0aeb152..dc97dcf 100755
--- a/SimpleCaptcha/Captcha.php
+++ b/SimpleCaptcha/Captcha.php
@@ -264,7 +264,7 @@
function badLoginKey() {
global $wgRequest;
$ip = $wgRequest->getIP();
- return wfMemcKey( 'captcha', 'badlogin', 'ip', $ip );
+ return wfGlobalCacheKey( 'captcha', 'badlogin', 'ip', $ip );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/270663
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If5533f222eae9dc540b7c79606d7e7ce613f4e13
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ConfirmEdit
Gerrit-Branch: master
Gerrit-Owner: Brian Wolff <[email protected]>
Gerrit-Reviewer: CSteipp <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
