jenkins-bot has submitted this change and it was merged.
Change subject: Resources: Narrow down dependencies on 'oojs-ui' to the smaller
modules
......................................................................
Resources: Narrow down dependencies on 'oojs-ui' to the smaller modules
I wasn't reading through them very carefully, so it's possible
that some of the 'oojs-ui-widgets' could be narrowed down further
to just 'oojs-ui-core', but this is good enough for me. At least
we're no longer loading toolbars everywhere.
Change-Id: I58799e22f9c0a2f78c1b4a02c4b7af576157883a
---
M resources/Resources.php
1 file changed, 11 insertions(+), 9 deletions(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/Resources.php b/resources/Resources.php
index b4e4a27..908f29c 100644
--- a/resources/Resources.php
+++ b/resources/Resources.php
@@ -957,7 +957,8 @@
'dependencies' => [
'mediawiki.messagePoster',
'mediawiki.Title',
- 'oojs-ui',
+ 'oojs-ui-core',
+ 'oojs-ui-windows',
],
'messages' => [
'feedback-adding',
@@ -993,7 +994,7 @@
'scripts' => 'resources/src/mediawiki/mediawiki.filewarning.js',
'styles' =>
'resources/src/mediawiki/mediawiki.filewarning.less',
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-core',
],
],
'mediawiki.ForeignApi' => [
@@ -1186,7 +1187,8 @@
'resources/src/mediawiki/mediawiki.Upload.BookletLayout.css',
],
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-core',
+ 'oojs-ui-windows',
'oojs-ui.styles.icons-content',
'oojs-ui.styles.icons-editing-advanced',
'mediawiki.Title',
@@ -1803,7 +1805,7 @@
'mediawiki.special.pageLanguage' => [
'scripts' =>
'resources/src/mediawiki.special/mediawiki.special.pageLanguage.js',
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-core',
],
],
'mediawiki.special.pagesWithProp' => [
@@ -2069,7 +2071,7 @@
],
],
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-widgets',
'mediawiki.widgets.styles',
// TitleInputWidget
'mediawiki.Title',
@@ -2115,7 +2117,7 @@
'mw-widgets-dateinput-placeholder-month',
],
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-widgets',
'moment',
],
'targets' => [ 'desktop', 'mobile' ],
@@ -2179,7 +2181,7 @@
'period-pm',
],
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-core',
],
'targets' => [ 'desktop', 'mobile' ],
],
@@ -2189,7 +2191,7 @@
'resources/src/mediawiki.widgets/mw.widgets.CategorySelector.js',
],
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-widgets',
'mediawiki.api',
'mediawiki.ForeignApi',
'mediawiki.Title',
@@ -2204,7 +2206,7 @@
'resources/src/mediawiki.widgets/mw.widgets.UserInputWidget.js',
],
'dependencies' => [
- 'oojs-ui',
+ 'oojs-ui-core',
],
'targets' => [ 'desktop', 'mobile' ],
],
--
To view, visit https://gerrit.wikimedia.org/r/268193
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I58799e22f9c0a2f78c1b4a02c4b7af576157883a
Gerrit-PatchSet: 4
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
