jenkins-bot has submitted this change and it was merged.
Change subject: Align mixin whitespace to CSS/Less coding guidelines
......................................................................
Align mixin whitespace to CSS/Less coding guidelines
Aligning mixin whitespace to CSS/Less coding guidelines. Also fix some minor
inconsistencies and add browser support comments.
Change-Id: I50841e6062e59513def49719dc7a04956002de0e
---
M resources/src/mediawiki.less/mediawiki.mixins.animation.less
M resources/src/mediawiki.less/mediawiki.mixins.less
M resources/src/mediawiki.less/mediawiki.mixins.rotation.less
3 files changed, 37 insertions(+), 37 deletions(-)
Approvals:
Jdlrobson: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.animation.less
b/resources/src/mediawiki.less/mediawiki.mixins.animation.less
index ec3cddc..fd615b7 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.animation.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.animation.less
@@ -1,12 +1,12 @@
-.animation (...) {
- -webkit-animation: @arguments;
- -moz-animation: @arguments;
- -o-animation: @arguments;
- animation: @arguments;
+.animation( ... ) {
+ -webkit-animation: @arguments; // Chrome 4-42, Safari 4-8, Opera 15-29,
Android 2.1-4.4.4
+ -moz-animation: @arguments; // Firefox 5-15
+ -o-animation: @arguments; // Opera 12.1
+ animation: @arguments; // Chrome 43+, Firefox 16+, IE 10+, Edge 12+,
Safari 9+, Opera 30+, iOS 9+, Android 47+
}
-.transform-rotate (@deg) {
- -webkit-transform: rotate(@deg);
- -moz-transform: rotate(@deg);
- transform: rotate(@deg);
+.transform-rotate( @deg ) {
+ -webkit-transform: rotate( @deg );
+ -moz-transform: rotate( @deg );
+ transform: rotate( @deg );
}
\ No newline at end of file
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.less
b/resources/src/mediawiki.less/mediawiki.mixins.less
index a550cbe..a4dca02 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.less
@@ -8,22 +8,22 @@
//
// See <http://lesscss.org/#-mixins> for more information about how to write
mixins.
-.background-image(@url) {
- background-image: e('/* @embed */') url(@url);
+.background-image( @url ) {
+ background-image: e( '/* @embed */' ) url( @url );
}
// Deprecated in MW 1.27
-.background-size(@width, @height) {
+.background-size( @width, @height ) {
// Vendor prefix is added to support Android 2
-webkit-background-size: @width @height;
background-size: @width @height;
}
-.vertical-gradient(@startColor: gray, @endColor: white, @startPos: 0, @endPos:
100%) {
+.vertical-gradient( @startColor: gray, @endColor: white, @startPos: 0,
@endPos: 100% ) {
background-color: @endColor;
- background-image: -moz-linear-gradient( top, @startColor @startPos,
@endColor @endPos ); // Firefox 3.6+
background-image: -webkit-gradient( linear, left top, left bottom,
color-stop( @startPos, @startColor ), color-stop( @endPos, @endColor ) ); //
Safari 4+, Chrome 2+
background-image: -webkit-linear-gradient( top, @startColor @startPos,
@endColor @endPos ); // Safari 5.1+, Chrome 10+
+ background-image: -moz-linear-gradient( top, @startColor @startPos,
@endColor @endPos ); // Firefox 3.6+
background-image: linear-gradient( @startColor @startPos, @endColor
@endPos ); // Standard
}
@@ -35,47 +35,47 @@
//
// We do not embed the fallback image on the assumption that the gain for old
browsers
// is not worth the harm done to modern ones.
-.background-image-svg(@svg, @fallback) {
- background-image: url(@fallback);
- background-image: linear-gradient(transparent, transparent), e('/*
@embed */') url(@svg);
+.background-image-svg( @svg, @fallback ) {
+ background-image: url( @fallback );
+ background-image: linear-gradient( transparent, transparent ), e( '/*
@embed */' ) url( @svg );
// Do not serve SVG to Opera 12, bad rendering with border-radius or
background-size (T87504)
- background-image: -o-linear-gradient(transparent, transparent),
url(@fallback);
+ background-image: -o-linear-gradient( transparent, transparent ), url(
@fallback );
}
-.list-style-image(@url) {
- list-style-image: e('/* @embed */') url(@url);
+.list-style-image( @url ) {
+ list-style-image: e( '/* @embed */' ) url( @url );
}
-.list-style-image-svg(@svg, @fallback) {
- list-style-image: e('/* @embed */') url(@svg);
+.list-style-image-svg( @svg, @fallback ) {
+ list-style-image: e( '/* @embed */' ) url( @svg );
/* Fallback to PNG bullet for IE 8 and below using CSS hack */
- list-style-image: e('/* @embed */') url(@fallback) e('\9');
+ list-style-image: e( '/* @embed */' ) url( @fallback ) e( '\9' );
}
-.transition(@value) {
+.transition( @value ) {
-webkit-transition: @value; // Safari 3.1-6.0, iOS 3.2-6.1, Android
2.1-4.3
-moz-transition: @value; // Firefox 4-15
transition: @value; // Chrome 26+, Firefox 16+, IE 10+, Safari 6.1+,
Opera 12.1+, iOS 7+, Android 4.4+
}
-.box-sizing(@value) {
+.box-sizing( @value ) {
-webkit-box-sizing: @value; // Safari 3.1-5.0, iOS 3.2-4.3, Android
2.1-3.0
-moz-box-sizing: @value; // Firefox 4-28,
box-sizing: @value; // Chrome 10+, Firefox 29+, IE 8+, Safari 5.1+,
Opera 10+, iOS 5+, Android 4+
}
-.box-shadow(@value) {
+.box-shadow( @value ) {
-webkit-box-shadow: @value; // Safari 3.1-5.0, iOS 3.2-4.3, Android
2.1-3.0
box-shadow: @value; // Chrome 10+, Firefox 4+, IE 9+, Safari 5.1+,
Opera 11+, iOS 5+, Android 4+
}
-.column-count(@value) {
+.column-count( @value ) {
-webkit-column-count: @value;
-moz-column-count: @value;
column-count: @value;
}
-.column-width(@value) {
+.column-width( @value ) {
-webkit-column-width: @value; // Chrome Any, Safari 3+, Opera 15+
-moz-column-width: @value; // Firefox 1.5+
column-width: @value; // IE 10+, Opera 11.1-12.1
@@ -87,18 +87,18 @@
break-inside: avoid-column; // IE 10+, Opera 11.1-12.1
}
-.flex-display(@display: flex) {
+.flex-display( @display: flex ) {
display: ~"-webkit-@{display}"; // iOS 6-, Safari 3.1-6
display: ~"-moz-@{display}"; // Firefox 21-
display: ~"-ms-@{display}box"; // IE 10
display: @display;
}
-.flex(@grow: 1, @shrink: 1, @width: auto, @order: 1) {
+.flex( @grow: 1, @shrink: 1, @width: auto, @order: 1 ) {
// For 2009/2012 spec alignment consistency with current default
-webkit-box-pack: justify; // iOS 6-, Safari 3.1-6
-moz-box-pack: justify; // Firefox 21-
- -ms-flex-pack: justify; // IE10 (2012 spec)
+ -ms-flex-pack: justify; // IE 10 (2012 spec)
justify-content: space-between; // Current default
// 2009 spec only supports 'flexible' as opposed to grow (flexPositive)
@@ -107,11 +107,11 @@
-moz-box-flex: @grow; // Firefox 21-
width: @width; // Fallback for flex-basis
- -ms-flex: @grow @shrink @width; // IE10
+ -ms-flex: @grow @shrink @width; // IE 10
flex: @grow @shrink @width;
-webkit-box-ordinal-group: @order; // iOS 6-, Safari 3.1-6
-moz-box-ordinal-group: @order; // Firefox 21-
- -ms-flex-order: @order; // IE10
+ -ms-flex-order: @order; // IE 10
order: @order;
}
diff --git a/resources/src/mediawiki.less/mediawiki.mixins.rotation.less
b/resources/src/mediawiki.less/mediawiki.mixins.rotation.less
index 85b6bd4..a404286 100644
--- a/resources/src/mediawiki.less/mediawiki.mixins.rotation.less
+++ b/resources/src/mediawiki.less/mediawiki.mixins.rotation.less
@@ -3,12 +3,12 @@
// of whether .rotation is used.
@import "mediawiki.mixins.animation";
-.rotate-frames () {
+.rotate-frames() {
from {
- .transform-rotate(0deg);
+ .transform-rotate( 0deg );
}
to {
- .transform-rotate(360deg);
+ .transform-rotate( 360deg );
}
}
@@ -25,5 +25,5 @@
}
.rotation( @time ) {
- .animation(rotate, @time, infinite, linear);
+ .animation( rotate, @time, infinite, linear );
}
--
To view, visit https://gerrit.wikimedia.org/r/269577
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I50841e6062e59513def49719dc7a04956002de0e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: VolkerE <[email protected]>
Gerrit-Reviewer: Edokter <[email protected]>
Gerrit-Reviewer: Jack Phoenix <[email protected]>
Gerrit-Reviewer: Jdlrobson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits