Bartosz Dziewoński has uploaded a new change for review.
https://gerrit.wikimedia.org/r/276217
Change subject: MediaWikiTheme: Remove broken remnant of d6b05bc0
......................................................................
MediaWikiTheme: Remove broken remnant of d6b05bc0
This should've been removed in 3d36cac7, but it seems I missed it.
It causes buttons with `{ framed: false, flags: [ 'primary' ] }`
(admittedly, a fairly stupid combination) to have invisible icon.
Change-Id: Ibb8db8af965b9fbf5bc7af6b6f8dc4c552daa662
---
M src/themes/mediawiki/MediaWikiTheme.js
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/oojs/ui refs/changes/17/276217/1
diff --git a/src/themes/mediawiki/MediaWikiTheme.js
b/src/themes/mediawiki/MediaWikiTheme.js
index f0ce1b8..cf69717 100644
--- a/src/themes/mediawiki/MediaWikiTheme.js
+++ b/src/themes/mediawiki/MediaWikiTheme.js
@@ -35,8 +35,7 @@
isFramed = element.supports( [ 'isFramed' ] ) &&
element.isFramed();
isActive = element.supports( [ 'isActive' ] ) &&
element.isActive();
if (
- ( isFramed && ( isActive || element.isDisabled() ||
element.hasFlag( 'primary' ) ) ) ||
- ( !isFramed && element.hasFlag( 'primary' ) )
+ ( isFramed && ( isActive || element.isDisabled() ||
element.hasFlag( 'primary' ) ) )
) {
variants.invert = true;
} else {
--
To view, visit https://gerrit.wikimedia.org/r/276217
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibb8db8af965b9fbf5bc7af6b6f8dc4c552daa662
Gerrit-PatchSet: 1
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
