jenkins-bot has submitted this change and it was merged.
Change subject: testsuitegenerator: Change values tested for 'flags' config
options
......................................................................
testsuitegenerator: Change values tested for 'flags' config options
Test both 'constructive' and 'primary' to better verify that correct
icon variants are chosen in MediaWiki theme.
This exposed an issue where a button with { framed: false, flags: 'primary' }
would have a different-colored icon in PHP and JS, fixed in
Ibb8db8af965b9fbf5bc7af6b6f8dc4c552daa662.
Change-Id: I353791f7398d9f6f74a255345d5ce4ae220c72b3
---
M bin/testsuitegenerator.rb
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Jforrester: Looks good to me, approved
jenkins-bot: Verified
diff --git a/bin/testsuitegenerator.rb b/bin/testsuitegenerator.rb
index 074d507..1713060 100644
--- a/bin/testsuitegenerator.rb
+++ b/bin/testsuitegenerator.rb
@@ -51,7 +51,7 @@
'maxLength' => [100],
'icon' => ['image'],
'indicator' => ['down'],
- 'flags' => %w[constructive],
+ 'flags' => %w[constructive primary],
'label' => expandos['string'] + ['', ' '],
# these are defined by Element and would bloat the tests
'classes' => true,
--
To view, visit https://gerrit.wikimedia.org/r/276215
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I353791f7398d9f6f74a255345d5ce4ae220c72b3
Gerrit-PatchSet: 4
Gerrit-Project: oojs/ui
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
