jenkins-bot has submitted this change and it was merged.
Change subject: Template Dialog: pushPending while the dialog is closing
......................................................................
Template Dialog: pushPending while the dialog is closing
Double-clicking the "insert" button would double-insert the template. Counting
the close as a pending action avoids that.
Bug: T129725
Change-Id: I41af7c051fd54004cecd563d7a6cf8fdb452840f
---
M modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
1 file changed, 2 insertions(+), 1 deletion(-)
Approvals:
Alex Monk: Looks good to me, approved
Jforrester: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
index 4ddf49a..34693c2 100644
--- a/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
+++ b/modules/ve-mw/ui/dialogs/ve.ui.MWTemplateDialog.js
@@ -428,7 +428,8 @@
dialog.transclusionModel.insertTransclusionNode( dialog.getFragment() );
}
- dialog.close( { action: action } );
+ dialog.pushPending();
+ dialog.close( { action: action } ).always(
dialog.popPending.bind( dialog ) );
} ).always( deferred.resolve );
return deferred;
--
To view, visit https://gerrit.wikimedia.org/r/279387
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I41af7c051fd54004cecd563d7a6cf8fdb452840f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Esanders <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
