[MediaWiki-commits] [Gerrit] Make some TablePager methods actually protected - change (mediawiki/core)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Make some TablePager methods actually protected
......................................................................


Make some TablePager methods actually protected

* getTableClass
* getNavClass
* getSortHeaderClass

Change-Id: I459ca456149635e3300c7ca7cfed4c1edc1c12b1
---
M includes/pager/TablePager.php
M includes/specials/SpecialProtectedpages.php
M includes/specials/pagers/BlockListPager.php
M includes/specials/pagers/ImageListPager.php
4 files changed, 8 insertions(+), 11 deletions(-)

Approvals:
  Florianschmidtwelzow: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/pager/TablePager.php b/includes/pager/TablePager.php
index e22ceba..0a89e4e 100644
--- a/includes/pager/TablePager.php
+++ b/includes/pager/TablePager.php
@@ -264,26 +264,23 @@
        }
 
        /**
-        * @protected
         * @return string
         */
-       function getTableClass() {
+       protected function getTableClass() {
                return 'TablePager';
        }
 
        /**
-        * @protected
         * @return string
         */
-       function getNavClass() {
+       protected function getNavClass() {
                return 'TablePager_nav';
        }
 
        /**
-        * @protected
         * @return string
         */
-       function getSortHeaderClass() {
+       protected function getSortHeaderClass() {
                return 'TablePager_sort';
        }
 
diff --git a/includes/specials/SpecialProtectedpages.php 
b/includes/specials/SpecialProtectedpages.php
index 8e9636e..54b471e 100644
--- a/includes/specials/SpecialProtectedpages.php
+++ b/includes/specials/SpecialProtectedpages.php
@@ -549,7 +549,7 @@
                ];
        }
 
-       public function getTableClass() {
+       protected function getTableClass() {
                return parent::getTableClass() . ' mw-protectedpages';
        }
 
diff --git a/includes/specials/pagers/BlockListPager.php 
b/includes/specials/pagers/BlockListPager.php
index cfaf5c5..d822976 100644
--- a/includes/specials/pagers/BlockListPager.php
+++ b/includes/specials/pagers/BlockListPager.php
@@ -241,7 +241,7 @@
                return $info;
        }
 
-       public function getTableClass() {
+       protected function getTableClass() {
                return parent::getTableClass() . ' mw-blocklist';
        }
 
diff --git a/includes/specials/pagers/ImageListPager.php 
b/includes/specials/pagers/ImageListPager.php
index 258ac83..45fe5c4 100644
--- a/includes/specials/pagers/ImageListPager.php
+++ b/includes/specials/pagers/ImageListPager.php
@@ -561,15 +561,15 @@
                $form->displayForm( '' );
        }
 
-       function getTableClass() {
+       protected function getTableClass() {
                return parent::getTableClass() . ' listfiles';
        }
 
-       function getNavClass() {
+       protected function getNavClass() {
                return parent::getNavClass() . ' listfiles_nav';
        }
 
-       function getSortHeaderClass() {
+       protected function getSortHeaderClass() {
                return parent::getSortHeaderClass() . ' listfiles_sort';
        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/282453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I459ca456149635e3300c7ca7cfed4c1edc1c12b1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Ricordisamoa <ricordisa...@openmailbox.org>
Gerrit-Reviewer: Florianschmidtwelzow <florian.schmidt.stargatewis...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits