Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/285383
Change subject: Update scalable object when setting dimensions
......................................................................
Update scalable object when setting dimensions
This scalable object is cached, so this is required for
the dialog to open with the correct size the second time.
Also use bounded dimensions when updating the preview.
Change-Id: I771ec667c9af9fa64158fbc7a3435bc6a113d2c5
---
M modules/ve-maps/ve.ui.MWMapsDialog.js
1 file changed, 18 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer
refs/changes/83/285383/1
diff --git a/modules/ve-maps/ve.ui.MWMapsDialog.js
b/modules/ve-maps/ve.ui.MWMapsDialog.js
index 706b4f9..c4ada4c 100644
--- a/modules/ve-maps/ve.ui.MWMapsDialog.js
+++ b/modules/ve-maps/ve.ui.MWMapsDialog.js
@@ -110,7 +110,9 @@
return;
}
- dimensions = this.dimensions.getDimensions();
+ dimensions = this.scalable.getBoundedDimensions(
+ this.dimensions.getDimensions()
+ );
center = this.map && this.map.getCenter();
// Set container width for centering
@@ -172,6 +174,21 @@
/**
* @inheritdoc ve.ui.MWExtensionWindow
*/
+ve.ui.MWMapsDialog.prototype.insertOrUpdateNode = function () {
+ // Parent method
+ ve.ui.MWMapsDialog.super.prototype.insertOrUpdateNode.apply( this,
arguments );
+
+ // Update scalable
+ this.scalable.setCurrentDimensions(
+ this.scalable.getBoundedDimensions(
+ this.dimensions.getDimensions()
+ )
+ );
+};
+
+/**
+ * @inheritdoc ve.ui.MWExtensionWindow
+ */
ve.ui.MWMapsDialog.prototype.updateMwData = function ( mwData ) {
var center, latitude, longitude, zoom,
dimensions = this.scalable.getBoundedDimensions(
--
To view, visit https://gerrit.wikimedia.org/r/285383
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I771ec667c9af9fa64158fbc7a3435bc6a113d2c5
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
