Brion VIBBER has uploaded a new change for review.
https://gerrit.wikimedia.org/r/289900
Change subject: Don't resample audio with ffmpeg2theora, it's unreliable
......................................................................
Don't resample audio with ffmpeg2theora, it's unreliable
A/V sync can drift badly over time when resampling audio with
ffmpeg2theora, such as 48k -> 44.1 kHz. Just let audio through
with its source rate for .ogv output for now to avoid this.
Bug: T135581
Change-Id: I0183f2e13e8615ba4f28bc7315530304deba7837
---
M WebVideoTranscode/WebVideoTranscode.php
1 file changed, 0 insertions(+), 4 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TimedMediaHandler
refs/changes/00/289900/1
diff --git a/WebVideoTranscode/WebVideoTranscode.php
b/WebVideoTranscode/WebVideoTranscode.php
index 010e21c..dcf5a72 100644
--- a/WebVideoTranscode/WebVideoTranscode.php
+++ b/WebVideoTranscode/WebVideoTranscode.php
@@ -87,7 +87,6 @@
'videoBitrate' => '160',
'framerate' => '15',
'audioQuality' => '-1',
- 'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
'twopass' => 'false', //
will be overridden by $wgTmhTheoraTwoPassEncoding
@@ -102,7 +101,6 @@
'maxSize' => '426x240',
'videoBitrate' => '512',
'audioQuality' => '0',
- 'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
'twopass' => 'false', //
will be overridden by $wgTmhTheoraTwoPassEncoding
@@ -117,7 +115,6 @@
'maxSize' => '640x360',
'videoBitrate' => '1024',
'audioQuality' => '1',
- 'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
'twopass' => 'false', //
will be overridden by $wgTmhTheoraTwoPassEncoding
@@ -132,7 +129,6 @@
'maxSize' => '854x480',
'videoBitrate' => '2048',
'audioQuality' => '2',
- 'samplerate' => '44100',
'channels' => '2',
'noUpscaling' => 'true',
'twopass' => 'false', //
will be overridden by $wgTmhTheoraTwoPassEncoding
--
To view, visit https://gerrit.wikimedia.org/r/289900
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0183f2e13e8615ba4f28bc7315530304deba7837
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TimedMediaHandler
Gerrit-Branch: master
Gerrit-Owner: Brion VIBBER <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
