Umherirrender has submitted this change and it was merged.
Change subject: registration: Ignore short variables in
convertExtensionToRegistration
......................................................................
registration: Ignore short variables in convertExtensionToRegistration
substr returns false when the string is shorter than the initial
position, which makes array_key_exists freak out.
Change-Id: I38c2dd3a1ae5d700d66ff590dda4be67e4dc5514
---
M maintenance/convertExtensionToRegistration.php
1 file changed, 3 insertions(+), 0 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
Umherirrender: Verified; Looks good to me, approved
diff --git a/maintenance/convertExtensionToRegistration.php
b/maintenance/convertExtensionToRegistration.php
index f9dd58c..aab2087 100644
--- a/maintenance/convertExtensionToRegistration.php
+++ b/maintenance/convertExtensionToRegistration.php
@@ -94,6 +94,9 @@
$globalSettings = $this->getAllGlobals();
foreach ( $vars as $name => $value ) {
$realName = substr( $name, 2 ); // Strip 'wg'
+ if ( $realName === false ) {
+ continue;
+ }
// If it's an empty array that we likely set, skip it
if ( is_array( $value ) && count( $value ) === 0 &&
in_array( $realName, $__settings ) ) {
--
To view, visit https://gerrit.wikimedia.org/r/289864
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I38c2dd3a1ae5d700d66ff590dda4be67e4dc5514
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Parent5446 <[email protected]>
Gerrit-Reviewer: Umherirrender <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
