jenkins-bot has submitted this change and it was merged.
Change subject: Log autocreation attempts in SessionManager
......................................................................
Log autocreation attempts in SessionManager
Also fix a typo.
Bug: T125184
Change-Id: I7e5ebcfdfd3aa37e131454855f4b7142e24906c4
---
M includes/Setup.php
M includes/session/SessionManager.php
2 files changed, 9 insertions(+), 4 deletions(-)
Approvals:
Anomie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/Setup.php b/includes/Setup.php
index e57b96a..10fa212 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -850,15 +850,20 @@
if ( $sessionUser->getId() === 0 && User::isValidUserName(
$sessionUser->getName() ) ) {
$ps_autocreate = Profiler::instance()->scopedProfileIn( $fname
. '-autocreate' );
if ( $wgDisableAuthManager ) {
- MediaWiki\Session\SessionManager::autoCreateUser(
$sessionUser );
+ $res =
MediaWiki\Session\SessionManager::autoCreateUser( $sessionUser );
} else {
- MediaWiki\Auth\AuthManager::singleton()->autoCreateUser(
+ $res =
MediaWiki\Auth\AuthManager::singleton()->autoCreateUser(
$sessionUser,
-
MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSSION,
+
MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSION,
true
);
}
Profiler::instance()->scopedProfileOut( $ps_autocreate );
+ \MediaWiki\Logger\LoggerFactory::getInstance( 'authmanager'
)->info( 'Autocreation attempt', [
+ 'event' => 'autocreate',
+ 'status' => $res,
+ ] );
+ unset( $res );
}
unset( $sessionUser );
}
diff --git a/includes/session/SessionManager.php
b/includes/session/SessionManager.php
index c3481e8..3e5ef3b 100644
--- a/includes/session/SessionManager.php
+++ b/includes/session/SessionManager.php
@@ -383,7 +383,7 @@
wfDeprecated( __METHOD__, '1.27' );
return
\MediaWiki\Auth\AuthManager::singleton()->autoCreateUser(
$user,
-
\MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSSION,
+
\MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSION,
false
)->isGood();
}
--
To view, visit https://gerrit.wikimedia.org/r/270350
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I7e5ebcfdfd3aa37e131454855f4b7142e24906c4
Gerrit-PatchSet: 7
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
