[MediaWiki-commits] [Gerrit] Log autocreation attempts in SessionManager - change (mediawiki/core)

[Code Review]

Gergő Tisza has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/290468

Change subject: Log autocreation attempts in SessionManager
......................................................................

Log autocreation attempts in SessionManager

Also fix a typo.

Bug: T125184
Change-Id: I7e5ebcfdfd3aa37e131454855f4b7142e24906c4
(cherry picked from commit b71e6664540152201d7742479df91e8ec1b16d50)
---
M includes/Setup.php
M includes/session/SessionManager.php
2 files changed, 9 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/68/290468/1

diff --git a/includes/Setup.php b/includes/Setup.php
index 253313e..7ec72fa 100644
--- a/includes/Setup.php
+++ b/includes/Setup.php
@@ -860,15 +860,20 @@
        if ( $sessionUser->getId() === 0 && User::isValidUserName( 
$sessionUser->getName() ) ) {
                $ps_autocreate = Profiler::instance()->scopedProfileIn( $fname 
. '-autocreate' );
                if ( $wgDisableAuthManager ) {
-                       MediaWiki\Session\SessionManager::autoCreateUser( 
$sessionUser );
+                       $res = 
MediaWiki\Session\SessionManager::autoCreateUser( $sessionUser );
                } else {
-                       MediaWiki\Auth\AuthManager::singleton()->autoCreateUser(
+                       $res = 
MediaWiki\Auth\AuthManager::singleton()->autoCreateUser(
                                $sessionUser,
-                               
MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSSION,
+                               
MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSION,
                                true
                        );
                }
                Profiler::instance()->scopedProfileOut( $ps_autocreate );
+               \MediaWiki\Logger\LoggerFactory::getInstance( 'authmanager' 
)->info( 'Autocreation attempt', [
+                       'event' => 'autocreate',
+                       'status' => $res,
+               ] );
+               unset( $res );
        }
        unset( $sessionUser );
 }
diff --git a/includes/session/SessionManager.php 
b/includes/session/SessionManager.php
index 4c45c26..7c6b7bb 100644
--- a/includes/session/SessionManager.php
+++ b/includes/session/SessionManager.php
@@ -383,7 +383,7 @@
                        wfDeprecated( __METHOD__, '1.27' );
                        return 
\MediaWiki\Auth\AuthManager::singleton()->autoCreateUser(
                                $user,
-                               
\MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSSION,
+                               
\MediaWiki\Auth\AuthManager::AUTOCREATE_SOURCE_SESSION,
                                false
                        )->isGood();
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/290468
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I7e5ebcfdfd3aa37e131454855f4b7142e24906c4
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza <gti...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits