Mattflaschen has uploaded a new change for review. Change subject: For click to close, only return false if they click overlay. ......................................................................
For click to close, only return false if they click overlay. * return false corresponds to preventDefault and stopPropogation. * If someone clicks on a greyed out area, they may not devote attention to what they're clicking on. * If it's fully visible, they generally will. Change-Id: Ib5cfee82cf7761162c24b519ee38747240375204 --- M guiders-1.2.8.js 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/GuidedTour/guiders refs/changes/97/45297/1 -- To view, visit https://gerrit.wikimedia.org/r/45297 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib5cfee82cf7761162c24b519ee38747240375204 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/GuidedTour/guiders Gerrit-Branch: master Gerrit-Owner: Mattflaschen <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
