Massaf has submitted this change and it was merged. Change subject: For click to close, only return false if they click overlay. ......................................................................
For click to close, only return false if they click overlay. If we return false, their click will hide the guider but not have any other effect (e.g. it will not follow a link). * return false corresponds to preventDefault and stopPropogation. * If someone clicks on a greyed out area, they may not devote attention to what they're clicking on. * If it's fully visible, they generally will. Change-Id: Ib5cfee82cf7761162c24b519ee38747240375204 --- M guiders-1.2.8.js 1 file changed, 3 insertions(+), 1 deletion(-) Approvals: Massaf: Verified; Looks good to me, approved -- To view, visit https://gerrit.wikimedia.org/r/45297 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib5cfee82cf7761162c24b519ee38747240375204 Gerrit-PatchSet: 3 Gerrit-Project: mediawiki/extensions/GuidedTour/guiders Gerrit-Branch: master Gerrit-Owner: Mattflaschen <[email protected]> Gerrit-Reviewer: Massaf <[email protected]> Gerrit-Reviewer: Mattflaschen <[email protected]> Gerrit-Reviewer: Ori.livneh <[email protected]> Gerrit-Reviewer: Spage <[email protected]> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
