Subramanya Sastry has uploaded a new change for review. https://gerrit.wikimedia.org/r/293787
Change subject: Minor: Simplification of nested ifs ...................................................................... Minor: Simplification of nested ifs Change-Id: I9abce33125f34cd01f9574bdb95b3a4f8479fd42 --- M lib/html2wt/LinkHandler.js 1 file changed, 3 insertions(+), 4 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/services/parsoid refs/changes/87/293787/1 diff --git a/lib/html2wt/LinkHandler.js b/lib/html2wt/LinkHandler.js index 78e0bbb..3066ebf 100644 --- a/lib/html2wt/LinkHandler.js +++ b/lib/html2wt/LinkHandler.js @@ -120,10 +120,9 @@ // if a WikiLink has an absolute URL. // (This may get converted back to a WikiLink below, in the interwiki // handling code.) - if (rtData.type === 'mw:WikiLink') { - if (/^(\w+:)?\/\//.test(rtData.href) || /^\//.test(rtData.origHref)) { - rtData.type = 'mw:ExtLink'; - } + if (rtData.type === 'mw:WikiLink' && + ((/^(\w+:)?\/\//.test(rtData.href) || /^\//.test(rtData.origHref)) { + rtData.type = 'mw:ExtLink'; } // Now get the target from rt data -- To view, visit https://gerrit.wikimedia.org/r/293787 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9abce33125f34cd01f9574bdb95b3a4f8479fd42 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/services/parsoid Gerrit-Branch: master Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits