jenkins-bot has submitted this change and it was merged.
Change subject: Minor: Simplification of nested ifs
......................................................................
Minor: Simplification of nested ifs
Change-Id: I9abce33125f34cd01f9574bdb95b3a4f8479fd42
---
M lib/html2wt/LinkHandler.js
1 file changed, 3 insertions(+), 4 deletions(-)
Approvals:
Arlolra: Looks good to me, approved
jenkins-bot: Verified
diff --git a/lib/html2wt/LinkHandler.js b/lib/html2wt/LinkHandler.js
index 78e0bbb..a17f19a 100644
--- a/lib/html2wt/LinkHandler.js
+++ b/lib/html2wt/LinkHandler.js
@@ -120,10 +120,9 @@
// if a WikiLink has an absolute URL.
// (This may get converted back to a WikiLink below, in the interwiki
// handling code.)
- if (rtData.type === 'mw:WikiLink') {
- if (/^(\w+:)?\/\//.test(rtData.href) ||
/^\//.test(rtData.origHref)) {
- rtData.type = 'mw:ExtLink';
- }
+ if (rtData.type === 'mw:WikiLink' &&
+ (/^(\w+:)?\/\//.test(rtData.href) ||
/^\//.test(rtData.origHref))) {
+ rtData.type = 'mw:ExtLink';
}
// Now get the target from rt data
--
To view, visit https://gerrit.wikimedia.org/r/293787
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9abce33125f34cd01f9574bdb95b3a4f8479fd42
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/services/parsoid
Gerrit-Branch: master
Gerrit-Owner: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: Arlolra <abrea...@wikimedia.org>
Gerrit-Reviewer: Cscott <canan...@wikimedia.org>
Gerrit-Reviewer: Subramanya Sastry <ssas...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
