jenkins-bot has submitted this change and it was merged.
Change subject: Remove useless sort parameter to printArray()
......................................................................
Remove useless sort parameter to printArray()
All callers use the default
Change-Id: If2a5cd64242f3b3d9ad9a99f5af7fb5b93438e8e
---
M maintenance/findHooks.php
1 file changed, 3 insertions(+), 6 deletions(-)
Approvals:
Legoktm: Looks good to me, approved
jenkins-bot: Verified
diff --git a/maintenance/findHooks.php b/maintenance/findHooks.php
index d44581c..a8bed54 100644
--- a/maintenance/findHooks.php
+++ b/maintenance/findHooks.php
@@ -328,15 +328,12 @@
}
/**
- * Nicely output the array
+ * Nicely sort an print an array
* @param string $msg A message to show before the value
* @param array $arr
- * @param bool $sort Whether to sort the array (Default: true)
*/
- private function printArray( $msg, $arr, $sort = true ) {
- if ( $sort ) {
- asort( $arr );
- }
+ private function printArray( $msg, $arr ) {
+ asort( $arr );
foreach ( $arr as $v ) {
$this->output( "$msg: $v\n" );
--
To view, visit https://gerrit.wikimedia.org/r/293751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If2a5cd64242f3b3d9ad9a99f5af7fb5b93438e8e
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <ch...@wikimedia.org>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Parent5446 <tylerro...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
