Chad has uploaded a new change for review. https://gerrit.wikimedia.org/r/293877
Change subject: Remove useless sort parameter to printArray() ...................................................................... Remove useless sort parameter to printArray() All callers use the default Change-Id: If2a5cd64242f3b3d9ad9a99f5af7fb5b93438e8e (cherry picked from commit 3e7c21a7c180f8cfb0a4da77d45c02ccba97e0e3) --- M maintenance/findHooks.php 1 file changed, 3 insertions(+), 6 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core refs/changes/77/293877/1 diff --git a/maintenance/findHooks.php b/maintenance/findHooks.php index d44581c..a8bed54 100644 --- a/maintenance/findHooks.php +++ b/maintenance/findHooks.php @@ -328,15 +328,12 @@ } /** - * Nicely output the array + * Nicely sort an print an array * @param string $msg A message to show before the value * @param array $arr - * @param bool $sort Whether to sort the array (Default: true) */ - private function printArray( $msg, $arr, $sort = true ) { - if ( $sort ) { - asort( $arr ); - } + private function printArray( $msg, $arr ) { + asort( $arr ); foreach ( $arr as $v ) { $this->output( "$msg: $v\n" ); -- To view, visit https://gerrit.wikimedia.org/r/293877 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: If2a5cd64242f3b3d9ad9a99f5af7fb5b93438e8e Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/core Gerrit-Branch: REL1_27 Gerrit-Owner: Chad <ch...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits