jenkins-bot has submitted this change and it was merged.

Change subject: NotificationBadgeWidget: Fix header getting larger when "Mark 
all as read" present
......................................................................


NotificationBadgeWidget: Fix header getting larger when "Mark all as read" 
present

The "Mark all as read" button had margins that made it just a little
bit taller than the header would otherwise be. This pushed the
bottom border of the header and the top border of the first notification
away from each other.

We only need top and right margins on this button, so drop the
bottom and left margins.

Bug: T137778
Change-Id: I8d47d84c79cbdad707b8cbaa8d43187c054755b3
---
M modules/styles/mw.echo.ui.NotificationBadgeWidget.less
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Sbisson: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less 
b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
index 83c4d77..9de6b64 100644
--- a/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
+++ b/modules/styles/mw.echo.ui.NotificationBadgeWidget.less
@@ -32,7 +32,7 @@
                                }
 
                                
.mw-echo-ui-notificationsWidget-markAllReadButton {
-                                       margin: 1.25em 1em;
+                                       margin: 1.25em 1em 0 0;
                                }
                        }
 

-- 
To view, visit https://gerrit.wikimedia.org/r/294279
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I8d47d84c79cbdad707b8cbaa8d43187c054755b3
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
Gerrit-Reviewer: Sbisson <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to