Esanders has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296233
Change subject: Ensure text version of counter is written to external links
when copying
......................................................................
Ensure text version of counter is written to external links when copying
Bug: T137503
Change-Id: Iae791253ea272847984fee5d0586dc302027f1bd
---
M modules/ve-mw/dm/nodes/ve.dm.MWNumberedExternalLinkNode.js
1 file changed, 21 insertions(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/33/296233/1
diff --git a/modules/ve-mw/dm/nodes/ve.dm.MWNumberedExternalLinkNode.js
b/modules/ve-mw/dm/nodes/ve.dm.MWNumberedExternalLinkNode.js
index 9011b9a..a8cc125 100644
--- a/modules/ve-mw/dm/nodes/ve.dm.MWNumberedExternalLinkNode.js
+++ b/modules/ve-mw/dm/nodes/ve.dm.MWNumberedExternalLinkNode.js
@@ -55,8 +55,27 @@
};
};
-ve.dm.MWNumberedExternalLinkNode.static.toDomElements = function (
dataElement, doc ) {
- var domElement = doc.createElement( 'a' );
+ve.dm.MWNumberedExternalLinkNode.static.toDomElements = function (
dataElement, doc, converter ) {
+ var counter, offset,
+ node = this,
+ domElement = doc.createElement( 'a' );
+
+ // Ensure there is a text version of the counter in the clipboard
+ // as external documents may not have the same stylesheet - and Firefox
+ // discards empty tags on copy.
+ if ( converter.isForClipboard() ) {
+ counter = 1;
+ offset = converter.documentData.indexOf( dataElement );
+
+ if ( offset !== -1 ) {
+ converter.documentData.slice( 0, offset ).forEach(
function ( el ) {
+ if ( el.type && el.type === node.name ) {
+ counter++;
+ }
+ } );
+ }
+ domElement.appendChild( doc.createTextNode( '[' + counter + ']'
) );
+ }
domElement.setAttribute( 'href', dataElement.attributes.href );
domElement.setAttribute( 'rel', 'mw:ExtLink' );
return [ domElement ];
--
To view, visit https://gerrit.wikimedia.org/r/296233
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iae791253ea272847984fee5d0586dc302027f1bd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Esanders <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
