Catrope has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296958
Change subject: Fix JS error when marking foreign notifications as read
......................................................................
Fix JS error when marking foreign notifications as read
Apparently we need to pass the source name instead of the
model name here, because the model name is "xwiki".
But I don't really understand why. This code needs cleanup.
Bug: T139114
Change-Id: I4a7e3113d40888e4a1bd2d744dbea6e777968375
---
M modules/ui/mw.echo.ui.SingleNotificationItemWidget.js
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Echo
refs/changes/58/296958/1
diff --git a/modules/ui/mw.echo.ui.SingleNotificationItemWidget.js
b/modules/ui/mw.echo.ui.SingleNotificationItemWidget.js
index 7cf7f0f..23cc9c6 100644
--- a/modules/ui/mw.echo.ui.SingleNotificationItemWidget.js
+++ b/modules/ui/mw.echo.ui.SingleNotificationItemWidget.js
@@ -68,7 +68,7 @@
this.controller.markSingleItemRead(
this.model.getId(),
- this.model.getModelName(),
+ this.model.getSource(),
this.model.isForeign(),
!!isRead
);
--
To view, visit https://gerrit.wikimedia.org/r/296958
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4a7e3113d40888e4a1bd2d744dbea6e777968375
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Catrope <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
