jenkins-bot has submitted this change and it was merged.
Change subject: Fix multiple domain check when changing password
......................................................................
Fix multiple domain check when changing password
Check LdapPrimaryAuthenticationProvider::hasMultipleDomains rather than
non-existent LdapPrimaryAuthenticationProvider::hasDomain.
Change-Id: I56c11b179afc8087a19e55e66fe29f55aa413c73
(cherry picked from commit 8c474c44d07bb3c95ebb51d164c42a375f20040c)
---
M LdapPrimaryAuthenticationProvider.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Gergő Tisza: Looks good to me, approved
jenkins-bot: Verified
diff --git a/LdapPrimaryAuthenticationProvider.php
b/LdapPrimaryAuthenticationProvider.php
index 8c73b96..87ee2d0 100644
--- a/LdapPrimaryAuthenticationProvider.php
+++ b/LdapPrimaryAuthenticationProvider.php
@@ -368,7 +368,7 @@
return;
}
- if ( $this->hasDomain && $req->domain === null ) {
+ if ( $this->hasMultipleDomains && $req->domain === null
) {
return;
}
--
To view, visit https://gerrit.wikimedia.org/r/297543
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I56c11b179afc8087a19e55e66fe29f55aa413c73
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/LdapAuthentication
Gerrit-Branch: REL1_27
Gerrit-Owner: Gergő Tisza <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Gergő Tisza <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits