DLynch has uploaded a new change for review.
https://gerrit.wikimedia.org/r/304487
Change subject: Flag the help button as progressive
......................................................................
Flag the help button as progressive
This gives it visual indicators that it'll take you somewhere. Its previous
frameless-button appearance made it non-obvious that it was behaving as a
link.
Bug: T142484
Change-Id: I7732bf6db7ac63121d6ed1377c654ae8700895d1
---
M modules/ext.templateDataGenerator.ui.js
1 file changed, 2 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TemplateData
refs/changes/87/304487/1
diff --git a/modules/ext.templateDataGenerator.ui.js
b/modules/ext.templateDataGenerator.ui.js
index f7dea12..66164a1 100644
--- a/modules/ext.templateDataGenerator.ui.js
+++ b/modules/ext.templateDataGenerator.ui.js
@@ -216,7 +216,8 @@
classes: [
'tdg-editscreen-main-helplink' ],
href: mw.msg(
'templatedata-helplink-target' ),
target: '_blank',
- framed: false
+ framed: false,
+ flags: [ 'progressive' ]
} );
// Dialog
--
To view, visit https://gerrit.wikimedia.org/r/304487
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I7732bf6db7ac63121d6ed1377c654ae8700895d1
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TemplateData
Gerrit-Branch: master
Gerrit-Owner: DLynch <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
