jenkins-bot has submitted this change and it was merged.
Change subject: DiscussionParser stripSig from mention content
......................................................................
DiscussionParser stripSig from mention content
This will allow us to:
1) Fix a bug involving showing the sig in the snippets
of mentions (Something catrope mentioned to me but
I do not know of a bug number for it)
2) Send more accurate sameUser failure metrics to
graphite as signature links would never be counted
as a mention
Change-Id: I33677012673ae6e4665aaaf59d4f350602f7276a
---
M includes/DiscussionParser.php
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Catrope: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/DiscussionParser.php b/includes/DiscussionParser.php
index 67f2fc1..336a2e4 100644
--- a/includes/DiscussionParser.php
+++ b/includes/DiscussionParser.php
@@ -146,6 +146,7 @@
return;
}
$content = self::stripHeader( $content );
+ $content = self::stripSignature( $content, $title );
$userLinks = self::getUserLinks( $content, $title );
if ( !$userLinks ) {
--
To view, visit https://gerrit.wikimedia.org/r/304452
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I33677012673ae6e4665aaaf59d4f350602f7276a
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Echo
Gerrit-Branch: master
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: Catrope <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
