jenkins-bot has submitted this change and it was merged.
Change subject: Followup af6d9aba: $search is a string, not an object
......................................................................
Followup af6d9aba: $search is a string, not an object
Reusing variables means you end up turning a string to an object
and then confuse yourself by trying to pass it as a string again.
Change-Id: I82b5ca65864099c180d915055c43e6839bd4f4a2
(cherry picked from commit 1078340188890738f9abd73f95291d3348e2f71a)
---
M includes/PrefixSearch.php
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Chad: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/PrefixSearch.php b/includes/PrefixSearch.php
index 45c591a..a9179eb 100644
--- a/includes/PrefixSearch.php
+++ b/includes/PrefixSearch.php
@@ -37,8 +37,8 @@
* @return Array of strings
*/
public static function titleSearch( $search, $limit, $namespaces =
array() ) {
- $search = new StringPrefixSearch;
- return $search->search( $search, $limit, $namespaces );
+ $prefixSearch = new StringPrefixSearch;
+ return $prefixSearch->search( $search, $limit, $namespaces );
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/305481
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I82b5ca65864099c180d915055c43e6839bd4f4a2
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: REL1_23
Gerrit-Owner: Robert Vogel <[email protected]>
Gerrit-Reviewer: Chad <[email protected]>
Gerrit-Reviewer: Robert Vogel <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
