Addshore has uploaded a new change for review.
https://gerrit.wikimedia.org/r/308766
Change subject: Add temporary code to re-add WikEdDiff gadget after reloading a
diff
......................................................................
Add temporary code to re-add WikEdDiff gadget after reloading a diff
Bug: T143199
Change-Id: If839acfc86bc3640b91d37211b56bd62df2f210d
(cherry picked from commit effe850b57385f8882c633e7287733256c371643)
---
M modules/ext.RevisionSlider.DiffPage.js
1 file changed, 21 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/RevisionSlider
refs/changes/66/308766/1
diff --git a/modules/ext.RevisionSlider.DiffPage.js
b/modules/ext.RevisionSlider.DiffPage.js
index f6656b2..70e1515 100644
--- a/modules/ext.RevisionSlider.DiffPage.js
+++ b/modules/ext.RevisionSlider.DiffPage.js
@@ -1,4 +1,6 @@
( function ( mw, $ ) {
+ /* global wikEd */
+
/**
* Module handling diff page reloading and the RevisionSlider browser
history
*
@@ -63,6 +65,15 @@
.find(
'.mw-revslider-revisions-container' ).scrollLeft( scrollLeft );
mw.hook( 'wikipage.content' ).fire(
$contentText );
+
+ // In order to correctly interact with
third-party code (extensions and gadgets)
+ // Revision slider should trigger some general
(core) hook that other parties listen too
+ // Following wikEdDiff.js-specific code is
deprecated and will be removed in the future.
+ // WikEdDiff should be updated to use a hook.
+ if ( self.wikEdDiffDetected() ) {
+ self.reInitWikEdDiff();
+ }
+
}, function ( xhr ) {
$( 'table.diff[data-mw="interface"]'
).removeClass( 'mw-revslider-diff-loading' );
if ( xhr.statusText !== 'abort' ) {
@@ -78,6 +89,16 @@
} );
},
+ wikEdDiffDetected: function () {
+ return typeof wikEd !== 'undefined' && $(
'meta[name=wikEdDiffSetupFlag]' ).length !== 0;
+ },
+
+ reInitWikEdDiff: function () {
+ $( 'meta[name=wikEdDiffSetupFlag]' ).remove();
+ $( 'meta[name=wikEdDiffStartupFlag]' ).remove();
+ wikEd.DiffSetup();
+ },
+
/**
* Replaces the current state in the history stack
*
--
To view, visit https://gerrit.wikimedia.org/r/308766
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If839acfc86bc3640b91d37211b56bd62df2f210d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: wmf/1.28.0-wmf.18
Gerrit-Owner: Addshore <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
