Filippo Giunchedi has uploaded a new change for review.
https://gerrit.wikimedia.org/r/310835
Change subject: monitoring: validate check_prometheus args
......................................................................
monitoring: validate check_prometheus args
Change-Id: I9338a627d07c7d5d80914b3c06b2f081c6ee9598
---
M modules/monitoring/manifests/check_prometheus.pp
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/35/310835/1
diff --git a/modules/monitoring/manifests/check_prometheus.pp
b/modules/monitoring/manifests/check_prometheus.pp
index 3a53842..968dd29 100644
--- a/modules/monitoring/manifests/check_prometheus.pp
+++ b/modules/monitoring/manifests/check_prometheus.pp
@@ -84,6 +84,9 @@
$contact_group = 'admins'
)
{
+ validate_re($method, '^(gt|ge|lt|le|eq|ne)$')
+ validate_bool($nan_ok)
+
$command = $nan_ok ? {
true => 'check_prometheus_nan_ok',
default => 'check_prometheus',
--
To view, visit https://gerrit.wikimedia.org/r/310835
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9338a627d07c7d5d80914b3c06b2f081c6ee9598
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Filippo Giunchedi <fgiunch...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
