Elukey has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/310862

Change subject: Add a directive to mod_proxy_html's yarn configuration
......................................................................

Add a directive to mod_proxy_html's yarn configuration

Sadly a lot of a hrefs to replace in the yarn proxied content
are embedded in inline JS. This will slow down a bit the overall
rendering time but it will improve the user experience.

Bug: T116192
Change-Id: I1eecb795d7b1a440be9e486f534b22bf7b076216
---
M modules/mariadb
M modules/statistics/templates/yarn.wikimedia.org.erb
2 files changed, 10 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/62/310862/1

diff --git a/modules/mariadb b/modules/mariadb
index d8fb107..40d8639 160000
--- a/modules/mariadb
+++ b/modules/mariadb
@@ -1 +1 @@
-Subproject commit d8fb10738df0945260114f51715c059537db4342
+Subproject commit 40d86396f3494b57dc12bd6a6078998bc8975a44
diff --git a/modules/statistics/templates/yarn.wikimedia.org.erb 
b/modules/statistics/templates/yarn.wikimedia.org.erb
index 043b1a1..0f14d7a 100644
--- a/modules/statistics/templates/yarn.wikimedia.org.erb
+++ b/modules/statistics/templates/yarn.wikimedia.org.erb
@@ -31,9 +31,15 @@
         # The Jetty Webserver (responsible for the Yarn UI) returns HTML with 
hardcoded
         # links in the HTML hrefs, so we need a way to avoid broken links.
         ProxyHTMLEnable On
+        # ProxyHTMLExtended forces mod_proxy_html to parse CSS/JS files too
+        # causing performance penalties in the overall rendering time.
+        # Unfortunately this is needed since some analytics1001 links are
+        # contained in embedded JS script that cause a broken UI experience
+        # if left untouched.
+        ProxyHTMLExtended On
         ProxyHTMLLinks a href
-        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:8088/ / Lecn
-        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:19888/ / Lecn
+        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:8088/ / L
+        ProxyHTMLURLMap http://analytics1001.eqiad.wmnet:19888/ / L
     </Location>
 
     CustomLog /var/log/apache2/yarn.wikimedia.org-access.log wmf
@@ -46,4 +52,4 @@
 
     ProxyPass / http://analytics1001.eqiad.wmnet:8088/
     ProxyPassReverse / http://analytics1001.eqiad.wmnet:8088/
-</VirtualHost>
\ No newline at end of file
+</VirtualHost>

-- 
To view, visit https://gerrit.wikimedia.org/r/310862
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I1eecb795d7b1a440be9e486f534b22bf7b076216
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Elukey <ltosc...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to