Dbrant has uploaded a new change for review.
https://gerrit.wikimedia.org/r/311135
Change subject: Improve timing of hiding link preview when loading a new page.
......................................................................
Improve timing of hiding link preview when loading a new page.
Bug: T145697
Change-Id: I5ec56fd991b0bb1ac61bd6149d8c61752cab1ad6
---
M app/src/main/java/org/wikipedia/page/PageActivity.java
1 file changed, 2 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/35/311135/1
diff --git a/app/src/main/java/org/wikipedia/page/PageActivity.java
b/app/src/main/java/org/wikipedia/page/PageActivity.java
index b23d321..f2ee4a1 100644
--- a/app/src/main/java/org/wikipedia/page/PageActivity.java
+++ b/app/src/main/java/org/wikipedia/page/PageActivity.java
@@ -361,9 +361,6 @@
new LinkPreviewFunnel(app, entry.getSource()).logNavigate();
}
- // Close the link preview, if one is open.
- hideLinkPreview();
-
app.putCrashReportProperty("api", title.getSite().authority());
app.putCrashReportProperty("title", title.toString());
@@ -378,6 +375,8 @@
if (!pageFragment.isAdded()) {
return;
}
+ // Close the link preview, if one is open.
+ hideLinkPreview();
//is the new title the same as what's already being displayed?
if (position == TabPosition.CURRENT_TAB
&&
!pageFragment.getCurrentTab().getBackStack().isEmpty()
--
To view, visit https://gerrit.wikimedia.org/r/311135
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5ec56fd991b0bb1ac61bd6149d8c61752cab1ad6
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Dbrant <dbr...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
