jenkins-bot has submitted this change and it was merged. Change subject: Add missing dependencies for ControllerViewFactory ......................................................................
Add missing dependencies for ControllerViewFactory See https://integration.wikimedia.org/ci/job/mwext-mw-selenium-composer/4830/console and some others that started failing "randomly". I believe this is the reason. Bug: T142695 Change-Id: Ib64c8572f37a087ed3f334571660445c7377d8d8 --- M view/resources/wikibase/view/resources.php 1 file changed, 2 insertions(+), 0 deletions(-) Approvals: Jonas Kress (WMDE): Looks good to me, approved jenkins-bot: Verified diff --git a/view/resources/wikibase/view/resources.php b/view/resources/wikibase/view/resources.php index eba8eea..677c434 100644 --- a/view/resources/wikibase/view/resources.php +++ b/view/resources/wikibase/view/resources.php @@ -65,6 +65,8 @@ 'wikibase.view.ControllerViewFactory' => $moduleTemplate + array( 'scripts' => 'ControllerViewFactory.js', 'dependencies' => array( + 'jquery.cookie', + 'mediawiki.user', 'wikibase.view.__namespace', 'wikibase.view.ToolbarViewController', 'wikibase.view.ViewFactory' -- To view, visit https://gerrit.wikimedia.org/r/308566 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ib64c8572f37a087ed3f334571660445c7377d8d8 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Daniel Kinzler <daniel.kinz...@wikimedia.de> Gerrit-Reviewer: Hoo man <h...@online.de> Gerrit-Reviewer: Jonas Kress (WMDE) <jonas.kr...@wikimedia.de> Gerrit-Reviewer: Thiemo Mättig (WMDE) <thiemo.maet...@wikimedia.de> Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
