jenkins-bot has submitted this change and it was merged.
Change subject: Remove pointless options from style-only modules
......................................................................
Remove pointless options from style-only modules
* 'dependencies' and 'position' are ignored entirely for style-only
modules (loaded with addModuleStyles()).
* 'group' causes them to be loaded in a separate request, but has
no debugging benefits (see 046cbe84). It shouldn't have been added.
Change-Id: I00474662a803ce330e80c5cb47e28296ea322c4d
---
M extension.json
1 file changed, 2 insertions(+), 6 deletions(-)
Approvals:
Matthias Mullie: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index b6da172..7368a50 100644
--- a/extension.json
+++ b/extension.json
@@ -126,15 +126,11 @@
},
"ext.uploadWizard.page.styles": {
"styles": "resources/uploadWizard.noWizard.css",
- "targets": [ "desktop", "mobile" ],
- "group": "ext.uploadWizard"
+ "targets": [ "desktop", "mobile" ]
},
"ext.uploadWizard.uploadCampaign.display": {
"styles":
"resources/ext.uploadWizard.uploadCampaign.display.css",
- "position": "top",
- "dependencies": "mediawiki.ui.button",
- "targets": [ "desktop", "mobile" ],
- "group": "ext.uploadWizard"
+ "targets": [ "desktop", "mobile" ]
},
"ext.uploadWizard.uploadCampaign.list": {
"styles":
"resources/ext.uploadWizard.uploadCampaign.list.css",
--
To view, visit https://gerrit.wikimedia.org/r/313453
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I00474662a803ce330e80c5cb47e28296ea322c4d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Matthias Mullie <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
