jenkins-bot has submitted this change and it was merged.
Change subject: Use same 'next' button classes in upload & details step
......................................................................
Use same 'next' button classes in upload & details step
Both upload & details step use uw.controller.Step.prototype.showNext
to check if we can proceed with the upload (and update buttons
accordingly)
Said method assumes the normal 'next' button has class
.mwe-upwiz-file-next-all-ok, and will show/hide that one, so we
should be using that same classname here.
Change-Id: Icc1dcd2548a0eff2189f419a82a0305df9d83ee4
---
M resources/ui/steps/uw.ui.Details.js
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Bartosz Dziewoński: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/ui/steps/uw.ui.Details.js
b/resources/ui/steps/uw.ui.Details.js
index c7b7f61..97877e1 100644
--- a/resources/ui/steps/uw.ui.Details.js
+++ b/resources/ui/steps/uw.ui.Details.js
@@ -53,7 +53,7 @@
} ).on( 'click', startDetails );
this.$buttons.append(
- $( '<div>' ).addClass( 'mwe-upwiz-start-next
mwe-upwiz-file-endchoice' ).append( this.nextButton.$element )
+ $( '<div>' ).addClass( 'mwe-upwiz-file-next-all-ok
mwe-upwiz-file-endchoice' ).append( this.nextButton.$element )
);
this.nextButtonDespiteFailures = new OO.ui.ButtonWidget( {
@@ -114,7 +114,7 @@
// reset buttons on the details page
this.$div.find( '.mwe-upwiz-file-next-some-failed' ).hide();
this.$div.find( '.mwe-upwiz-file-next-all-failed' ).hide();
- this.$div.find( '.mwe-upwiz-start-next' ).show();
+ this.$div.find( '.mwe-upwiz-file-next-all-ok' ).show();
};
/**
--
To view, visit https://gerrit.wikimedia.org/r/314021
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc1dcd2548a0eff2189f419a82a0305df9d83ee4
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/UploadWizard
Gerrit-Branch: master
Gerrit-Owner: Matthias Mullie <[email protected]>
Gerrit-Reviewer: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
