Matthias Mullie has uploaded a new change for review. https://gerrit.wikimedia.org/r/315264
Change subject: Let children have same method signature as parent ...................................................................... Let children have same method signature as parent I assume there was no reason for these method signatures to be different from their parents. Otherwise, I would've expected an explicit empty array of uploads to have been passed. Not too much happens with these uploads anyway... Change-Id: I5a96743694ec10bb9876d50416fbfa93a59f4e71 --- M resources/controller/uw.controller.Thanks.js M resources/controller/uw.controller.Tutorial.js M resources/controller/uw.controller.Upload.js M resources/ui/steps/uw.ui.Upload.js 4 files changed, 7 insertions(+), 7 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UploadWizard refs/changes/64/315264/1 diff --git a/resources/controller/uw.controller.Thanks.js b/resources/controller/uw.controller.Thanks.js index 5d48705..848685d 100644 --- a/resources/controller/uw.controller.Thanks.js +++ b/resources/controller/uw.controller.Thanks.js @@ -49,7 +49,7 @@ return; } - uw.controller.Step.prototype.moveTo.call( this ); + uw.controller.Step.prototype.moveTo.call( this, uploads ); $.each( uploads, function ( i, upload ) { thanks.ui.addUpload( upload ); diff --git a/resources/controller/uw.controller.Tutorial.js b/resources/controller/uw.controller.Tutorial.js index 52d6b68..1cc3c89 100644 --- a/resources/controller/uw.controller.Tutorial.js +++ b/resources/controller/uw.controller.Tutorial.js @@ -72,7 +72,7 @@ } ); }; - uw.controller.Tutorial.prototype.moveTo = function () { + uw.controller.Tutorial.prototype.moveTo = function ( uploads ) { var tconf = mw.config.get( 'UploadWizardConfig' ).tutorial; if ( @@ -81,7 +81,7 @@ ) { this.skip(); } else { - uw.controller.Step.prototype.moveTo.call( this ); + uw.controller.Step.prototype.moveTo.call( this, uploads ); } }; diff --git a/resources/controller/uw.controller.Upload.js b/resources/controller/uw.controller.Upload.js index 06fd57d..ebcc972 100644 --- a/resources/controller/uw.controller.Upload.js +++ b/resources/controller/uw.controller.Upload.js @@ -83,9 +83,9 @@ this.ui.empty(); }; - uw.controller.Upload.prototype.moveTo = function () { + uw.controller.Upload.prototype.moveTo = function ( uploads ) { this.updateFileCounts( [] ); - uw.controller.Step.prototype.moveTo.call( this ); + uw.controller.Step.prototype.moveTo.call( this, uploads ); this.progressBar = undefined; }; diff --git a/resources/ui/steps/uw.ui.Upload.js b/resources/ui/steps/uw.ui.Upload.js index be0b2cf..2d6ee63 100644 --- a/resources/ui/steps/uw.ui.Upload.js +++ b/resources/ui/steps/uw.ui.Upload.js @@ -268,8 +268,8 @@ this.$flickrSelect.unbind(); }; - uw.ui.Upload.prototype.moveTo = function () { - uw.ui.Step.prototype.moveTo.call( this ); + uw.ui.Upload.prototype.moveTo = function ( uploads ) { + uw.ui.Step.prototype.moveTo.call( this, uploads ); this.$fileList.removeClass( 'mwe-upwiz-filled-filelist' ); -- To view, visit https://gerrit.wikimedia.org/r/315264 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I5a96743694ec10bb9876d50416fbfa93a59f4e71 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/UploadWizard Gerrit-Branch: master Gerrit-Owner: Matthias Mullie <mmul...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits