Ejegg has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/319373

Change subject: Downgrade missing details to warning for RecordCaptureJob
......................................................................

Downgrade missing details to warning for RecordCaptureJob

We'll eventually get them from the logs when we parse the audit.

Change-Id: Id82c4ec731c4e9652db6571bd9fcaa30e469327e
---
M PaymentProviders/Adyen/Jobs/RecordCaptureJob.php
1 file changed, 6 insertions(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/wikimedia/fundraising/SmashPig 
refs/changes/73/319373/1

diff --git a/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php 
b/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php
index 2db5924..8e23090 100644
--- a/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php
+++ b/PaymentProviders/Adyen/Jobs/RecordCaptureJob.php
@@ -65,7 +65,12 @@
                        $db->deleteMessage( $dbMessage );
 
                } else {
-                       $logger->error(
+                       // Sometimes we don't have a pending db row because the 
donor made
+                       // multiple attempts with the same order ID. It would 
be nice if
+                       // Adyen could prevent that, but let's not send a 
failmail since
+                       // we'll eventually get the donor details from the 
payments log
+                       // when we parse the audit.
+                       $logger->warning(
                                "Could not find a processable message for 
authorization Reference '{$this->originalReference}' " .
                                        "and order ID 
'{$this->merchantReference}'.",
                                $dbMessage

-- 
To view, visit https://gerrit.wikimedia.org/r/319373
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id82c4ec731c4e9652db6571bd9fcaa30e469327e
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/fundraising/SmashPig
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to