jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/327183 )
Change subject: mediawiki.special.apisandbox: Avoid bitwise tricks when
checking for integers
......................................................................
mediawiki.special.apisandbox: Avoid bitwise tricks when checking for integers
In addition to being more obvious than `n | 0`, `Math.floor( n )` also
works correctly for numbers outside of 32-bit int range.
Change-Id: I254457500e141c0dd4e28c707fb4a00c1b04c272
---
M resources/src/mediawiki.special/mediawiki.special.apisandbox.js
1 file changed, 1 insertion(+), 2 deletions(-)
Approvals:
Fomafix: Looks good to me, but someone else must approve
jenkins-bot: Verified
Jforrester: Looks good to me, approved
diff --git a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
index 60155fd..43321fe 100644
--- a/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
+++ b/resources/src/mediawiki.special/mediawiki.special.apisandbox.js
@@ -408,8 +408,7 @@
} else {
n = +value;
return !isNaN( n ) &&
isFinite( n ) &&
- //
eslint-disable-next-line no-bitwise
- ( n | 0 ) === n
&&
+ Math.floor( n )
=== n &&
n >= pi.min &&
n <= pi.apiSandboxMax;
}
} );
--
To view, visit https://gerrit.wikimedia.org/r/327183
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I254457500e141c0dd4e28c707fb4a00c1b04c272
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Bartosz Dziewoński <[email protected]>
Gerrit-Reviewer: Anomie <[email protected]>
Gerrit-Reviewer: Fomafix <[email protected]>
Gerrit-Reviewer: Jforrester <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
