Hello Yuvipanda,

I'd like you to do a code review.  Please visit

    https://gerrit.wikimedia.org/r/329595

to review the following change.


Change subject: puppetmaster: Specify $group for all repositories
......................................................................

puppetmaster: Specify $group for all repositories

Bug: T152060
Change-Id: I3466a4225980f1f13225551a13f3fc09c5fc2327
---
M modules/puppetmaster/manifests/gitclone.pp
1 file changed, 2 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/95/329595/1

diff --git a/modules/puppetmaster/manifests/gitclone.pp 
b/modules/puppetmaster/manifests/gitclone.pp
index 8c414ee..4b900a2 100644
--- a/modules/puppetmaster/manifests/gitclone.pp
+++ b/modules/puppetmaster/manifests/gitclone.pp
@@ -218,6 +218,7 @@
         git::clone { 'labs/private':
             require   => File["${puppetmaster::gitdir}/labs"],
             owner     => $user,
+            group     => $group,
             directory => "${puppetmaster::gitdir}/labs/private",
         }
 
@@ -232,6 +233,7 @@
         'operations/software':
             require   => File["${puppetmaster::gitdir}/operations"],
             owner     => $user,
+            group     => $group,
             directory => "${puppetmaster::gitdir}/operations/software",
             origin    => 
'https://gerrit.wikimedia.org/r/p/operations/software';
     }

-- 
To view, visit https://gerrit.wikimedia.org/r/329595
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3466a4225980f1f13225551a13f3fc09c5fc2327
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Tim Landscheidt <t...@tim-landscheidt.de>
Gerrit-Reviewer: Yuvipanda <yuvipa...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to