jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/330875 )
Change subject: See tags in method doc block ...................................................................... See tags in method doc block Also added missing use statement Change-Id: Ifeb1061c14ee370f59870224995b9029640f57e1 --- M repo/includes/ChangeOp/ChangeOpDeserializer.php 1 file changed, 6 insertions(+), 4 deletions(-) Approvals: WMDE-leszek: Looks good to me, approved jenkins-bot: Verified Jeroen De Dauw: Looks good to me, but someone else must approve Thiemo Mättig (WMDE): Looks good to me, but someone else must approve diff --git a/repo/includes/ChangeOp/ChangeOpDeserializer.php b/repo/includes/ChangeOp/ChangeOpDeserializer.php index 7fcfe24..d185d82 100644 --- a/repo/includes/ChangeOp/ChangeOpDeserializer.php +++ b/repo/includes/ChangeOp/ChangeOpDeserializer.php @@ -2,11 +2,11 @@ namespace Wikibase\Repo\ChangeOp; +use Wikibase\ChangeOp\ChangeOp; use Wikibase\ChangeOp\ChangeOpException; /** - * Interface for services that can construct a ChangeOp (or a series of changes wrapped in a - * ChangeOps object) from a JSON style array structure describing changes to an entity. + * Interface for services that can construct a ChangeOp from a JSON style array structure describing changes to an entity. * * @license GPL-2.0+ * @author Amir Sarabadani <[email protected]> @@ -20,8 +20,10 @@ * [ 'label' => [ 'zh' => [ 'remove' ], 'de' => [ 'value' => 'Foo' ] ] ] * * @throws ChangeOpException when the provided array is invalid. - * @return ChangeOp|null Returns null if there is no relevant change in the provided - * serialization. + * @return ChangeOp + * + * @see NullChangeOp If no change needs to be applied + * @see ChangeOps If series of changes needs to be applied */ public function createEntityChangeOp( array $changeRequest ); -- To view, visit https://gerrit.wikimedia.org/r/330875 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: Ifeb1061c14ee370f59870224995b9029640f57e1 Gerrit-PatchSet: 2 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: master Gerrit-Owner: Aleksey Bekh-Ivanov (WMDE) <[email protected]> Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]> Gerrit-Reviewer: Daniel Kinzler <[email protected]> Gerrit-Reviewer: Jeroen De Dauw <[email protected]> Gerrit-Reviewer: Ladsgroup <[email protected]> Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]> Gerrit-Reviewer: WMDE-leszek <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
