Niharika29 has uploaded a new change for review. ( 
https://gerrit.wikimedia.org/r/332769 )

Change subject: Only record cookie-block events in eventlogging.
......................................................................

Only record cookie-block events in eventlogging.

This change needs a corresponding change in the schema 
https://meta.wikimedia.org/wiki/Schema:CookieBlock
to change schema field data type to bool.

Change-Id: I8994b2ee0f4450430197869271c79a81d4427e11
---
M WikimediaEventsHooks.php
1 file changed, 13 insertions(+), 5 deletions(-)


  git pull 
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikimediaEvents 
refs/changes/69/332769/1

diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php
index 8b6f928..0805034 100644
--- a/WikimediaEventsHooks.php
+++ b/WikimediaEventsHooks.php
@@ -617,12 +617,20 @@
                $isCookieSetOnAutoblock = $rc->getConfig()->get( 
'CookieSetOnAutoblock' );
                $blockCookieVal = $request->getCookie( 'BlockID' );
                $trigger = $user->blockTrigger;
-               if ( $isCookieSetOnAutoblock && $blockCookieVal > 0 && $blocked 
&& $trigger !== false ) {
-                       $logData = [
-                               'ip' => $request->getIP(),
-                               'block' => $trigger
-                       ];
+               if ( $isCookieSetOnAutoblock && $blockCookieVal > 0 && $blocked 
) {
+                       if ( $trigger == 'cookie-block' ) {
+                               $logData = [
+                                       'ip' => $request->getIP(),
+                                       'block' => true
+                               ];
+                       } else {
+                               $logData = [
+                                       'ip' => $request->getIP(),
+                                       'block' => false
+                               ];
+                       }
                        EventLogging::logEvent( 'CookieBlock', 16046548, 
$logData );
                }
        }
+
 }

-- 
To view, visit https://gerrit.wikimedia.org/r/332769
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I8994b2ee0f4450430197869271c79a81d4427e11
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikimediaEvents
Gerrit-Branch: master
Gerrit-Owner: Niharika29 <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to