jenkins-bot has submitted this change and it was merged. ( https://gerrit.wikimedia.org/r/332769 )
Change subject: Only record cookie-block events in eventlogging. ...................................................................... Only record cookie-block events in eventlogging. This change needs a corresponding change in the schema https://meta.wikimedia.org/wiki/Schema:CookieBlock to change block field data type to bool. Bug: T146230 Change-Id: I8994b2ee0f4450430197869271c79a81d4427e11 --- M WikimediaEventsHooks.php 1 file changed, 4 insertions(+), 3 deletions(-) Approvals: BryanDavis: Looks good to me, approved jenkins-bot: Verified diff --git a/WikimediaEventsHooks.php b/WikimediaEventsHooks.php index 8b6f928..9eca2bb 100644 --- a/WikimediaEventsHooks.php +++ b/WikimediaEventsHooks.php @@ -617,12 +617,13 @@ $isCookieSetOnAutoblock = $rc->getConfig()->get( 'CookieSetOnAutoblock' ); $blockCookieVal = $request->getCookie( 'BlockID' ); $trigger = $user->blockTrigger; - if ( $isCookieSetOnAutoblock && $blockCookieVal > 0 && $blocked && $trigger !== false ) { + if ( $isCookieSetOnAutoblock && $blockCookieVal > 0 && $blocked ) { $logData = [ 'ip' => $request->getIP(), - 'block' => $trigger + 'is_cookie_block' => $trigger === 'cookie-block' ]; - EventLogging::logEvent( 'CookieBlock', 16046548, $logData ); + EventLogging::logEvent( 'CookieBlock', 16241436, $logData ); } } + } -- To view, visit https://gerrit.wikimedia.org/r/332769 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I8994b2ee0f4450430197869271c79a81d4427e11 Gerrit-PatchSet: 7 Gerrit-Project: mediawiki/extensions/WikimediaEvents Gerrit-Branch: master Gerrit-Owner: Niharika29 <[email protected]> Gerrit-Reviewer: BryanDavis <[email protected]> Gerrit-Reviewer: Gergő Tisza <[email protected]> Gerrit-Reviewer: Kaldari <[email protected]> Gerrit-Reviewer: Niharika29 <[email protected]> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
