Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/333675 )
Change subject: Inject SetAliases dependencies
......................................................................
Inject SetAliases dependencies
Bug: T156022
Change-Id: I3d8936fa97b8d354ccb99a6efae6cedd5f821440
---
M repo/Wikibase.php
M repo/includes/Api/SetAliases.php
2 files changed, 22 insertions(+), 10 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/75/333675/1
diff --git a/repo/Wikibase.php b/repo/Wikibase.php
index 740d8ff..e6d0474 100644
--- a/repo/Wikibase.php
+++ b/repo/Wikibase.php
@@ -204,7 +204,17 @@
}
];
$wgAPIModules['wbsearchentities'] =
Wikibase\Repo\Api\SearchEntities::class;
- $wgAPIModules['wbsetaliases'] = Wikibase\Repo\Api\SetAliases::class;
+ $wgAPIModules['wbsetaliases'] = [
+ 'class' => Wikibase\Repo\Api\SetAliases::class,
+ 'factory' => function ( ApiMain $mainModule, $moduleName ) {
+ return new Wikibase\Repo\Api\SetAliases(
+ $mainModule,
+ $moduleName,
+
Wikibase\Repo\WikibaseRepo::getDefaultInstance()->getChangeOpFactoryProvider()
+ ->getFingerprintChangeOpFactory()
+ );
+ }
+ ];
$wgAPIModules['wbeditentity'] = Wikibase\Repo\Api\EditEntity::class;
$wgAPIModules['wblinktitles'] = Wikibase\Repo\Api\LinkTitles::class;
$wgAPIModules['wbsetsitelink'] = Wikibase\Repo\Api\SetSiteLink::class;
diff --git a/repo/includes/Api/SetAliases.php b/repo/includes/Api/SetAliases.php
index cc0ebaa..bb87851 100644
--- a/repo/includes/Api/SetAliases.php
+++ b/repo/includes/Api/SetAliases.php
@@ -3,7 +3,9 @@
namespace Wikibase\Repo\Api;
use ApiMain;
+use ApiUsageException;
use InvalidArgumentException;
+use Wikibase\Summary;
use Wikibase\ChangeOp\ChangeOp;
use Wikibase\ChangeOp\ChangeOpAliases;
use Wikibase\ChangeOp\ChangeOps;
@@ -32,15 +34,15 @@
/**
* @param ApiMain $mainModule
* @param string $moduleName
- * @param string $modulePrefix
+ * @param FingerprintChangeOpFactory $termChangeOpFactory
*/
- public function __construct( ApiMain $mainModule, $moduleName,
$modulePrefix = '' ) {
- parent::__construct( $mainModule, $moduleName, $modulePrefix );
-
- $wikibaseRepo = WikibaseRepo::getDefaultInstance();
- $changeOpFactoryProvider =
$wikibaseRepo->getChangeOpFactoryProvider();
-
- $this->termChangeOpFactory =
$changeOpFactoryProvider->getFingerprintChangeOpFactory();
+ public function __construct(
+ ApiMain $mainModule,
+ $moduleName,
+ FingerprintChangeOpFactory $termChangeOpFactory
+ ) {
+ parent::__construct( $mainModule, $moduleName );
+ $this->termChangeOpFactory = $termChangeOpFactory;
}
/**
@@ -170,7 +172,7 @@
/**
* @param array $params
*
- * @return ChangeOpAliases
+ * @return ChangeOpAliases[]
*/
private function getChangeOps( array $params ) {
$changeOps = array();
--
To view, visit https://gerrit.wikimedia.org/r/333675
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d8936fa97b8d354ccb99a6efae6cedd5f821440
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
