Mholloway has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/334349 )
Change subject: Make description editing respect page protection
......................................................................
Make description editing respect page protection
Change-Id: I45f99bf1af8fb75ec61a454ab9bcfb0dc87e3119
---
M app/src/main/java/org/wikipedia/descriptions/DescriptionEditClient.java
1 file changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia
refs/changes/49/334349/1
diff --git
a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditClient.java
b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditClient.java
index a3046a4..2a86efb 100644
--- a/app/src/main/java/org/wikipedia/descriptions/DescriptionEditClient.java
+++ b/app/src/main/java/org/wikipedia/descriptions/DescriptionEditClient.java
@@ -10,6 +10,7 @@
import org.wikipedia.dataclient.retrofit.RetrofitException;
import org.wikipedia.login.User;
import org.wikipedia.page.Page;
+import org.wikipedia.page.PageProperties;
import org.wikipedia.page.PageTitle;
import org.wikipedia.server.mwapi.MwServiceError;
@@ -40,9 +41,11 @@
}
public static boolean isEditAllowed(@NonNull Page page) {
- return
ENABLED_LANGUAGES.contains(page.getTitle().getWikiSite().languageCode())
- && page.getPageProperties() != null
- &&
!TextUtils.isEmpty(page.getPageProperties().getWikiBaseItem());
+ PageProperties props = page.getPageProperties();
+ return props != null
+ && props.canEdit()
+ && !TextUtils.isEmpty(props.getWikiBaseItem())
+ &&
ENABLED_LANGUAGES.contains(page.getTitle().getWikiSite().languageCode());
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/334349
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45f99bf1af8fb75ec61a454ab9bcfb0dc87e3119
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Mholloway <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
