JGirault has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/336912 )
Change subject: Map attributions should be visible when sidebar is open
......................................................................
Map attributions should be visible when sidebar is open
Bug: T152978
Change-Id: Ic9ea2dcee9d60b8eed9e63177e892fc19433e85d
---
M modules/dialog/dialog.js
M styles/dialog.less
2 files changed, 10 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Kartographer
refs/changes/12/336912/1
diff --git a/modules/dialog/dialog.js b/modules/dialog/dialog.js
index 05d64e1..a89d9b2 100644
--- a/modules/dialog/dialog.js
+++ b/modules/dialog/dialog.js
@@ -93,6 +93,8 @@
return;
}
+ dialog.$body.toggleClass(
'mw-kartographer-mapDialog-sidebar-opened', open );
+
mw.track( 'mediawiki.kartographer', {
action: open ? 'sidebar-show' : 'sidebar-hide',
isFullScreen: true,
diff --git a/styles/dialog.less b/styles/dialog.less
index afb4c9b..d9ec966 100644
--- a/styles/dialog.less
+++ b/styles/dialog.less
@@ -1,4 +1,5 @@
@import '../lib/wmui-base.less';
+@sidebarWidth: 320px;
/* Dialog footer */
.mw-kartographer-mapDialog-foot {
@@ -29,7 +30,7 @@
bottom: 4.5em;
z-index: 2;
border-left: @border-base;
- width: 321px; /* 320+1 so border is hidden on common 320px wide mobile
devices */
+ width: @sidebarWidth + 1px; /* 320+1 so border is hidden on common
320px wide mobile devices */
box-sizing: border-box;
background-color: #fff;
padding: 3em 2em 1em;
@@ -131,3 +132,9 @@
background-size: 32px;
background-repeat: no-repeat;
}
+
+.mw-kartographer-mapDialog-sidebar-opened {
+ .leaflet-right.leaflet-bottom {
+ right: @sidebarWidth;
+ }
+}
--
To view, visit https://gerrit.wikimedia.org/r/336912
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic9ea2dcee9d60b8eed9e63177e892fc19433e85d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Kartographer
Gerrit-Branch: master
Gerrit-Owner: JGirault <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
