jenkins-bot has submitted this change and it was merged. (
https://gerrit.wikimedia.org/r/337789 )
Change subject: Remove unused variables from client and repo tests
......................................................................
Remove unused variables from client and repo tests
Change-Id: If65883aab0f05c24a9fcd38ab5b6fba93558b0f9
---
M client/tests/phpunit/includes/Usage/UsageTrackerContractTester.php
M repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
M repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
3 files changed, 3 insertions(+), 3 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
Aleksey Bekh-Ivanov (WMDE): Checked; Looks good to me, but someone else must
approve
jenkins-bot: Verified
diff --git a/client/tests/phpunit/includes/Usage/UsageTrackerContractTester.php
b/client/tests/phpunit/includes/Usage/UsageTrackerContractTester.php
index edae89a..26f087f 100644
--- a/client/tests/phpunit/includes/Usage/UsageTrackerContractTester.php
+++ b/client/tests/phpunit/includes/Usage/UsageTrackerContractTester.php
@@ -113,7 +113,7 @@
}
public function testPruneUsages() {
- list( $usagesT1, $usagesT2 ) = $this->getTestUsages();
+ list( $usagesT1, ) = $this->getTestUsages();
$this->tracker->addUsedEntities( 23, $usagesT1 );
$this->tracker->addUsedEntities( 24, $usagesT1 );
diff --git a/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
b/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
index b502b8a..0a63a23 100644
--- a/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
+++ b/repo/tests/phpunit/includes/Specials/SpecialItemByTitleTest.php
@@ -173,7 +173,7 @@
$subPage = self::EXISTING_WIKI . '/' . self::EXISTING_PAGE;
/* @var WebResponse $response */
- list( $_, $response ) = $this->executeSpecialPage( $subPage );
+ list( , $response ) = $this->executeSpecialPage( $subPage );
$itemUrl = Title::newFromText( $itemId )->getFullURL();
$expectedUrl = wfExpandUrl( $itemUrl, PROTO_CURRENT );
diff --git
a/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
b/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
index 6d896b8..0c6d5a2 100644
---
a/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
+++
b/repo/tests/phpunit/includes/Specials/SpecialSetLabelDescriptionAliasesTest.php
@@ -259,7 +259,7 @@
$this->mockRepository->putEntity( $inputEntity );
$id = $inputEntity->getId();
- list( $output, $response ) = $this->executeSpecialPage(
$id->getSerialization(), $request );
+ list( , $response ) = $this->executeSpecialPage(
$id->getSerialization(), $request );
$redirect = $response instanceof FauxResponse ?
$response->getHeader( 'Location' ) : null;
// TODO: Look for an error message in $output.
--
To view, visit https://gerrit.wikimedia.org/r/337789
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: If65883aab0f05c24a9fcd38ab5b6fba93558b0f9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
Gerrit-Reviewer: WMDE-leszek <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
