Ladsgroup has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/344820 )
Change subject: Use mediawiki.ui for review form
......................................................................
Use mediawiki.ui for review form
It would be good to use OOUI for the whole thing but the codebase is a mess
Bug: T28256
Change-Id: Ic0a2950ae68f5ac06be460abb2c0ffb5f790502f
---
M frontend/FlaggablePageView.php
M frontend/RevisionReviewFormUI.php
2 files changed, 17 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/FlaggedRevs
refs/changes/20/344820/1
diff --git a/frontend/FlaggablePageView.php b/frontend/FlaggablePageView.php
index b1eb800..0108c63 100644
--- a/frontend/FlaggablePageView.php
+++ b/frontend/FlaggablePageView.php
@@ -1154,6 +1154,7 @@
}
# Build the review form as needed
if ( $rev && ( !$this->diffRevs || $this->isReviewableDiff ) ) {
+ $this->out->addModuleStyles( [ 'mediawiki.ui.button',
'mediawiki.ui.input' ] );
$form = new RevisionReviewFormUI( $this->getContext(),
$this->article, $rev );
# Default tags and existence of "reject" button depend
on context
if ( $this->diffRevs ) {
diff --git a/frontend/RevisionReviewFormUI.php
b/frontend/RevisionReviewFormUI.php
index 46a4970..ee13206 100644
--- a/frontend/RevisionReviewFormUI.php
+++ b/frontend/RevisionReviewFormUI.php
@@ -179,9 +179,20 @@
# Hide comment input if needed
if ( !$disabled ) {
- $form .= Xml::inputLabel(
- wfMessage( 'revreview-log' )->text(),
'wpReason', 'mw-fr-commentbox', 40, '',
- array( 'maxlength' => 255, 'class' =>
'fr-comment-box' )
+ $form .= Xml::label(
+ wfMessage( 'revreview-log' )->text(),
+ 'mw-fr-commentbox',
+ [ 'maxlength' => 255, 'class' =>
'fr-comment-box' ]
+ );
+ $form .= Xml::input(
+ 'wpReason',
+ 40,
+ '',
+ [
+ 'maxlength' => 255,
+ 'id' => 'mw-fr-commentbox',
+ 'class' => 'fr-comment-box mw-ui-input
mw-ui-input-inline',
+ ]
);
}
@@ -389,6 +400,7 @@
array(
'name' => 'wpApprove',
'id' => 'mw-fr-submit-accept',
+ 'class' => 'mw-ui-button
mw-ui-constructive',
'accesskey' => wfMessage( 'revreview-ak-review'
)->text(),
'title' => wfMessage( 'revreview-tt-flag'
)->text() . ' [' .
wfMessage( 'revreview-ak-review'
)->text() . ']'
@@ -401,6 +413,7 @@
array(
'name' => 'wpReject',
'id' => 'mw-fr-submit-reject',
+ 'class' => 'mw-ui-button
mw-ui-destructive',
'title' => wfMessage(
'revreview-tt-reject' )->text(),
) + ( $disabled ? $disAttrib : array() )
);
--
To view, visit https://gerrit.wikimedia.org/r/344820
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0a2950ae68f5ac06be460abb2c0ffb5f790502f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/FlaggedRevs
Gerrit-Branch: master
Gerrit-Owner: Ladsgroup <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
