Aleksey Bekh-Ivanov (WMDE) has uploaded a new change for review. (
https://gerrit.wikimedia.org/r/347572 )
Change subject: Fix `LexemeLanguageFieldObserver.tests.js` for jQuery 3.0
migration
......................................................................
Fix `LexemeLanguageFieldObserver.tests.js` for jQuery 3.0 migration
Test is failing because jQuery implementation is changed.
It used to set "display: block" disregarding the fact that
element is not in the visible DOM, now it does something differently.
Change-Id: I2a8ca23551ddec02812403b159ddc3b398cf5a9e
---
M tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
1 file changed, 15 insertions(+), 13 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/WikibaseLexeme
refs/changes/72/347572/1
diff --git
a/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
b/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
index 846524c..8d4c548 100644
--- a/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
+++ b/tests/qunit/special/formHelpers/LexemeLanguageFieldObserver.tests.js
@@ -1,54 +1,56 @@
/**
* @license GPL-2.0+
*/
-( function ( wb, $, QUnit ) {
+( function( wb, $, QUnit ) {
QUnit.module(
'wikibase.lexeme.special.formHelpers.LexemeLanguageFieldObserver' );
- var getMockItemLookup = function () {
+ var getMockItemLookup = function() {
return {
- fetchEntity: function () {
+ fetchEntity: function() {
var d = $.Deferred();
d.resolve( {} );
return d;
}
};
},
- getMockLanguageExtractor = function ( language ) {
+ getMockLanguageExtractor = function( language ) {
return {
- getLanguageFromItem: function () {
+ getLanguageFromItem: function() {
return language;
}
};
};
- QUnit.test( 'Given not all parameters provided, throws error', function
( assert ) {
+ QUnit.test( 'Given not all parameters provided, throws error',
function( assert ) {
var LanguageFieldObserver =
wb.lexeme.special.formHelpers.LexemeLanguageFieldObserver;
- assert.throws( function () {
+ assert.throws( function() {
new LanguageFieldObserver( null, getMockItemLookup(),
getMockLanguageExtractor() );
} );
- assert.throws( function () {
+ assert.throws( function() {
new LanguageFieldObserver( $( '<div/>' ), null,
getMockLanguageExtractor() );
} );
- assert.throws( function () {
+ assert.throws( function() {
new LanguageFieldObserver( $( '<div/>' ),
getMockItemLookup(), null );
} );
} );
- QUnit.test( 'Given the provided item has no language code statement,
lemma language field is shown', function ( assert ) {
+ QUnit.test( 'Given the provided item has no language code statement,
lemma language field is shown', function( assert ) {
var $field = $( '<div/>' ).css( 'display', 'none' ),
languageFieldObserver = new
wb.lexeme.special.formHelpers.LexemeLanguageFieldObserver(
$field,
getMockItemLookup(),
getMockLanguageExtractor()
);
+ $( 'body' ).append( $field );
- assert.ok( $field.css( 'display' ) === 'none' );
+ assert.equal( $field.css( 'display' ), 'none' );
languageFieldObserver.notify( 'Q123' );
- assert.ok( $field.css( 'display' ) === 'block' );
+ assert.equal( $field.css( 'display' ), 'block' );
+ $field.remove();
} );
- QUnit.test( 'Given the provided item has a language code statement,
lemma language field is hidden', function ( assert ) {
+ QUnit.test( 'Given the provided item has a language code statement,
lemma language field is hidden', function( assert ) {
var $field = $( '<div><input/></div>' ),
languageFieldObserver = new
wb.lexeme.special.formHelpers.LexemeLanguageFieldObserver(
$field,
--
To view, visit https://gerrit.wikimedia.org/r/347572
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a8ca23551ddec02812403b159ddc3b398cf5a9e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/WikibaseLexeme
Gerrit-Branch: master
Gerrit-Owner: Aleksey Bekh-Ivanov (WMDE) <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
